feat: use binding_nodejs_support_wasm - #442
Merged
marco-ippolito merged 2 commits intoSep 11, 2026
Merged
marco-ippolito merged 2 commits into
marco-ippolito merged 2 commits into
Conversation
avivkeller
commented
Jul 18, 2026
Member
Author
|
Bump @nodejs/typescript |
Member
|
Before shipping this, have you tried pasting inside node amaeo in the deps folder and see if it works? Before fully committing I want to make sure its feasible, also I dont want to ship a public api for ast manipulation. Its not in the scope of amaro, so it should stay private |
Member
|
Would excluding it from typings and documenting them as private/interal APIs work? |
Member
Author
|
Yes, I did! I also ran benchmarks and saw ~10% improvement in assert |
Member
Author
|
Bump @marco-ippolito |
Member
Author
|
Another friendly bump :-) |
Member
Author
|
@nodejs/typescript |
marco-ippolito
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://openjs-foundation.slack.com/archives/C07JHGVPMHV/p1782874417170689?thread_ts=1782598063.098319&cid=C07JHGVPMHV
The plan here is to make all of Node.js's internal AST parsing Amaro-based, removing our dependency on slower, JavaScript based parsers.